[Bug 573721] Review Request: javacc-maven-plugin - JavaCC Maven Plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573721

--- Comment #3 from Mary Ellen Foster <mefoster at gmail.com> 2010-03-16 11:51:57 EDT ---
Review:
OK: rpmlint must be run on every package. Output:
javacc-maven-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/javacc-maven-plugin
javacc-maven-plugin.src: W: invalid-url Source0:
javacc-maven-plugin-2.6.tar.bz2
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

False positives

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL.
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK: All build dependencies must be listed in BuildRequires
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly.
OK: Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: Packages must not own files or directories already owned by other packages.
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot}
OK: All filenames in rpm packages must be valid UTF-8.

In addition to the issue mentioned in comment #2, the main package should also
Require(post), Require(postun), and just generally Require jpackage-utils (the
first two for %update_maven_depmap, the last for directory ownership)

Other than that, looks good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.