[Bug 573848] Review Request: perl-NetPacket - Modules to assemble/disassemble network packets at the protocol level

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573848

--- Comment #1 from Chris Weyl <cweyl at alumni.drew.edu> 2010-03-17 00:24:47 EDT ---
So, aside from the spelling error in %description, everything looks good.

....except for the license.  I see references to the "Perl Artistic License",
and a (defunct) url is given to document it.  Given the age of the software, I
have to wonder if it's the Artistic v1, rather than v2.

I do see a github repo listed in META.yml; is there any chance we can query
upstream for clarification?

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2054702

Spec looks sane, clean and consistent; license is correct (Artistic 2.0);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
ac2ebb4084beab7f73eeb4e1a994d24636de2575 NetPacket-0.41.1.tar.gz
ac2ebb4084beab7f73eeb4e1a994d24636de2575 NetPacket-0.41.1.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-NetPacket-0.41.1-1.fc14.noarch.rpm <=====
====> rpmlint
perl-NetPacket.noarch: W: spelling-error %description -l en_US descendent ->
descendant, descender, descend
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides for perl-NetPacket-0.41.1-1.fc14.noarch.rpm
perl(NetPacket) = 0.41.1
perl-NetPacket = 0.41.1-1.fc14
perl(NetPacket::ARP) = 0.41.1
perl(NetPacket::Ethernet) = 0.41.1
perl(NetPacket::ICMP) = 0.41.1
perl(NetPacket::IGMP) = 0.41.1
perl(NetPacket::IP) = 0.41.1
perl(NetPacket::TCP) = 0.41.1
perl(NetPacket::UDP) = 0.41.1
====> requires for perl-NetPacket-0.41.1-1.fc14.noarch.rpm
perl(constant)  
perl(:MODULE_COMPAT_5.10.1)  
perl(NetPacket)  
perl(NetPacket::IP)  
perl(strict)  
perl(vars)  

=====> perl-NetPacket-0.41.1-1.fc14.src.rpm <=====
====> rpmlint
perl-NetPacket.src: W: spelling-error %description -l en_US descendent ->
descendant, descender, descend
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides for perl-NetPacket-0.41.1-1.fc14.src.rpm
====> requires for perl-NetPacket-0.41.1-1.fc14.src.rpm
perl(Module::Build)  
perl(Test::More)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.