[Bug 574026] Review Request: aic94xx-firmware - Adaptec SAS 44300, 48300, 58300 Sequencer Firmware for AIC94xx driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574026

Peter Lemenkov <lemenkov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |lemenkov at gmail.com
         AssignedTo|nobody at fedoraproject.org    |lemenkov at gmail.com
               Flag|                            |fedora-review?

--- Comment #1 from Peter Lemenkov <lemenkov at gmail.com> 2010-03-17 00:31:33 EDT ---
REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ rpmlint is NOT silent, but these messages are false positive.

Sulaco ~/rpmbuild/SPECS: rpmlint
../RPMS/noarch/aic94xx-firmware-30-1.fc12.noarch.rpm 
aic94xx-firmware.noarch: W: spelling-error Summary(en_US) Adaptec -> Adapter,
Adapted, Adaption
aic94xx-firmware.noarch: W: spelling-error %description -l en_US Adaptec ->
Adapter, Adapted, Adaption
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Sulaco ~/rpmbuild/SPECS:

+ The package is named according to the  Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.

Sulaco ~/rpmbuild/SPECS: sha256sum ../SOURCES/aic94xx-seq-30-1.tar.gz*
0608a919b95e65e8fe3c0cbc15f7e559716bda39a6efca863417a65f75e15478 
../SOURCES/aic94xx-seq-30-1.tar.gz
0608a919b95e65e8fe3c0cbc15f7e559716bda39a6efca863417a65f75e15478 
../SOURCES/aic94xx-seq-30-1.tar.gz.1
Sulaco ~/rpmbuild/SPECS:

+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.

- At the beginning of %install, the package MUST run rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).

+ All filenames in rpm packages are valid UTF-8.

Please, add "rm -rf %{buildroot}" at the beginning of %install section, and
I'll continue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.