[Bug 570951] Review Request: krb5-appl - Kerberos-aware telnet/ftp/rcp/rsh/rlogin (upstream split from krb5)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=570951

Sumit Bose <sbose at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Sumit Bose <sbose at redhat.com> 2010-03-18 13:03:17 EDT ---
The package looks good and builds in koji.

I get the following output from rpmlint:

krb5-appl.src: I: checking
krb5-appl.src: W: spelling-error Summary(en_US) Kerberos -> Kerosene, Kerbside,
Cerberus
krb5-appl.src: W: spelling-error Summary(en_US) rsh -> rah, rs, sh
krb5-appl.src: W: spelling-error Summary(en_US) rlogin -> logging, logician,
purloin
krb5-appl.src: W: spelling-error %description -l en_US rcp -> rcpt, rep, rip
krb5-appl.src: W: spelling-error %description -l en_US rsh -> rah, rs, sh
krb5-appl.src: W: spelling-error %description -l en_US rlogin -> logging,
logician, purloin
krb5-appl.src: I: checking-url http://web.mit.edu/kerberos/www/ (timeout 10
seconds)
krb5-appl.src:281: E: use-of-RPM_SOURCE_DIR
krb5-appl.src:110: W: mixed-use-of-spaces-and-tabs (spaces: line 93, tab: line
110)
krb5-appl.src: W: invalid-url Source1: krb5-appl-1.0.tar.gz.asc
krb5-appl.src: W: invalid-url Source0: krb5-appl-1.0.tar.gz
krb5-appl-clients.i686: I: checking
krb5-appl-clients.i686: W: spelling-error Summary(en_US) Kerberos -> Kerosene,
Kerbside, Cerberus
krb5-appl-clients.i686: I: checking-url http://web.mit.edu/kerberos/www/
(timeout 10 seconds)
krb5-appl-clients.i686: W: non-standard-dir-in-usr kerberos
krb5-appl-debuginfo.i686: I: checking
krb5-appl-debuginfo.i686: W: spelling-error Summary(en_US) krb -> orb, Krebs,
Kr
krb5-appl-debuginfo.i686: W: spelling-error %description -l en_US krb -> orb,
Krebs, Kr
krb5-appl-debuginfo.i686: I: checking-url http://web.mit.edu/kerberos/www/
(timeout 10 seconds)
krb5-appl-servers.i686: I: checking
krb5-appl-servers.i686: W: spelling-error Summary(en_US) Kerberos -> Kerosene,
Kerbside, Cerberus
krb5-appl-servers.i686: W: spelling-error Summary(en_US) rsh -> rah, rs, sh
krb5-appl-servers.i686: W: spelling-error Summary(en_US) rlogin -> logging,
logician, purloin
krb5-appl-servers.i686: W: spelling-error %description -l en_US rsh -> rah, rs,
sh
krb5-appl-servers.i686: W: spelling-error %description -l en_US rlogin ->
logging, logician, purloin
krb5-appl-servers.i686: I: checking-url http://web.mit.edu/kerberos/www/
(timeout 10 seconds)
krb5-appl-servers.i686: W: non-standard-dir-in-usr kerberos
4 packages and 0 specfiles checked; 1 errors, 19 warnings.

All warnings and errors can be ignored:
- the spelling errors can be ignored
- RPM_SOURCE_DIR is only mentioned in the changelog
- invalid-url: the upstream source is released as a tarball which contains
another tarball with the sources and in signature file, so there is no direct
url to the tarall with the sources
- mixed-use-of-spaces-and-tabs is detected wrongly
- non-standard-dir-in-usr, to be able to use the non-kerberized version of some
tools, e.g. rsh, as a fallback the kerberized versions a installed in a
seperate directory, the package takes care that the search patch is updated to
find the new tools

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.