[Bug 567257] Review Request: libfm - GIO-based library for file manager-like programs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567257

--- Comment #8 from Christoph Wickert <cwickert at fedoraproject.org> 2010-03-19 18:51:58 EDT ---
(In reply to comment #5)
> * License
>   - is GPLv2+

fixed

> * BR/Requires
>   - ">= 2.16.0" on "BR: gtk2-devel" is not needed because gtk2-devel
>     in currently supported Fedora branches all satisfy this dependency:
>     https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires

The explicit requires guideline doesn't apply here as I'm not requiring a
library. Only the version number could be omitted, if all currently supported
Fedora branches fulfilled this requirement, but EPEL does not.

>   - Would you explain why BR: gvfs-devel or R: gvfs is needed?
>     grep'ing gvfs returns nothing.

You are right, it's a runtime dependency only, not a BR. It's optional, but
highly recommended, otherwise things like trash:// or mounting of remote file
systems wont work.

> * %description
>   - Please don't repeat the same description on -gtk (note that
>     -gtk subpackage has R: libfm)

Why not? Only the first part of the description is the same, the rest is
different for the (sub)packages. IMO the description must be understandable for
every single package standalone because nether a package manager nor rpm -i
will show you the description of the required packages.

> * Directory ownership issue
> %{_sysconfdir}/xdg/libfm/
> %{_libdir}/libfm/

fixed.

> * -devel/-gtk-devel file splitting
>   - Well, I will say listing files in %_includedir/%name on -devel and
>     -gtk-devel in the current way is error-prone. Would you list files
>     in %_includedir/%name in some automated way like below?

thanks a lot, this is very smart.

> * pkgconfig .pc file

was fixed upstream in 0.1.5

latest files:
http://cwickert.fedorapeople.org/review/libfm.spec
http://cwickert.fedorapeople.org/review/libfm-0.1.9-1.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.