[Bug 575352] Review Request: perl-File-Read - Unique interface for reading one or more files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=575352

--- Comment #1 from Chris Weyl <cweyl at alumni.drew.edu> 2010-03-20 13:07:46 EDT ---
There seems to be an example file under eg/, why not throw it in %doc?

Looks good.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2064444

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
3ff055404c896280b88356db0995d22b22af101f File-Read-0.0801.tar.gz
3ff055404c896280b88356db0995d22b22af101f File-Read-0.0801.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-File-Read-0.0801-1.fc14.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-File-Read-0.0801-1.fc14.noarch.rpm
perl(File::Read) = 0.0801
perl-File-Read = 0.0801-1.fc14
====> requires for perl-File-Read-0.0801-1.fc14.noarch.rpm
perl(Carp)  
perl(Exporter)  
perl(File::Slurp)  
perl(:MODULE_COMPAT_5.10.1)  
perl(strict)  

=====> perl-File-Read-0.0801-1.fc14.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-File-Read-0.0801-1.fc14.src.rpm
====> requires for perl-File-Read-0.0801-1.fc14.src.rpm
perl(File::Slurp)  
perl(Module::Build)  
perl(Test::Distribution)  
perl(Test::More)  
perl(Test::Portability::Files)  

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.