[Bug 575377] Review Request: perl-CGI-Application-Plugin-DBIProfile - DBI profiling plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=575377

--- Comment #2 from Chris Weyl <cweyl at alumni.drew.edu> 2010-03-20 13:22:52 EDT ---
For some reason, I'm finding that rpmlint wants to replace "ProfileDumper"
with "Profiteering" hilariaous. :)

An explicit 'Requires' on CGI::Application might be in order; I'm having a
hard time coming up with a use-case that doesn't involve it being installed.

Looks good!

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2065058

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
3bf70fed1231f898cc29986af80a964f43e3b965
CGI-Application-Plugin-DBIProfile-0.07.tar.gz
3bf70fed1231f898cc29986af80a964f43e3b965
CGI-Application-Plugin-DBIProfile-0.07.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-CGI-Application-Plugin-DBIProfile-0.07-1.fc13.noarch.rpm <=====
====> rpmlint
perl-CGI-Application-Plugin-DBIProfile.noarch: W: spelling-error %description
-l en_US popup -> pop up, pop-up, popular
perl-CGI-Application-Plugin-DBIProfile.noarch: W: spelling-error %description
-l en_US DevPopup -> Depopulate, Develop, Depopulation
perl-CGI-Application-Plugin-DBIProfile.noarch: W: spelling-error %description
-l en_US ProfileDumper -> Profile Dumper, Profile-dumper, Profiteering
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
====> provides for
perl-CGI-Application-Plugin-DBIProfile-0.07-1.fc13.noarch.rpm
perl(CGI::Application::Plugin::DBIProfile) = 0.07
perl-CGI-Application-Plugin-DBIProfile = 0.07-1.fc13
perl(CGI::Application::Plugin::DBIProfile::Data) = 1.0
perl(CGI::Application::Plugin::DBIProfile::Driver) = 1.1
perl(CGI::Application::Plugin::DBIProfile::Graph::GDGraphInline)  
perl(CGI::Application::Plugin::DBIProfile::Graph::HTML)  
perl(CGI::Application::Plugin::DBIProfile::Graph::HTMLBarGraph)  
perl(CGI::Application::Plugin::DBIProfile::Graph::HTML::Horizontal)  
perl(CGI::Application::Plugin::DBIProfile::Graph::SVGTT)  
====> requires for
perl-CGI-Application-Plugin-DBIProfile-0.07-1.fc13.noarch.rpm
perl(base)  
perl(Carp)  
perl(CGI)  
perl(CGI::Application::Plugin::DBIProfile::Data)  
perl(CGI::Application::Plugin::DBIProfile::Driver)  
perl(Data::JavaScript)  
perl(DBI)  
perl(DBI::ProfileDumper)  
perl(GD::Graph::bars)  
perl(HTML::BarGraph)  
perl(HTML::Template)  
perl(IO::Scalar)  
perl(List::Util)  
perl(MIME::Base64)  
perl(:MODULE_COMPAT_5.10.1)  
perl(strict)  
perl(SVG::TT::Graph::Bar)  
perl(Symbol)  
perl(vars)  
perl(warnings)  

=====> perl-CGI-Application-Plugin-DBIProfile-0.07-1.fc13.src.rpm <=====
====> rpmlint
perl-CGI-Application-Plugin-DBIProfile.src: W: spelling-error %description -l
en_US popup -> pop up, pop-up, popular
perl-CGI-Application-Plugin-DBIProfile.src: W: spelling-error %description -l
en_US DevPopup -> Depopulate, Develop, Depopulation
perl-CGI-Application-Plugin-DBIProfile.src: W: spelling-error %description -l
en_US ProfileDumper -> Profile Dumper, Profile-dumper, Profiteering
perl-CGI-Application-Plugin-DBIProfile.src: W: invalid-url URL:
http://search.cpan.org/dist/CGI-Application-Plugin-DBIProfile/ <urlopen error
timed out>
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
====> provides for perl-CGI-Application-Plugin-DBIProfile-0.07-1.fc13.src.rpm
====> requires for perl-CGI-Application-Plugin-DBIProfile-0.07-1.fc13.src.rpm
perl(CGI::Application)  
perl(Data::JavaScript)  
perl(DBI)  
perl(HTML::Template)  
perl(IO::Scalar)  
perl(Module::Build)  
perl(Test::More)  
perl(Test::Pod)  

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.