[Bug 566403] Review Request: dnsmap - Passive DNS network mapper a.k.a. subdomains bruteforcer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566403

Michal Ambroz <rebus at seznam.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rebus at seznam.cz

--- Comment #4 from Michal Ambroz <rebus at seznam.cz> 2010-03-20 18:53:22 EDT ---
Hello,
I am not authorized to do a review, but I was gonna to try submit the package
review request so it makes sense I would do at least comments (review) of the
package to help it to het to Fedora.

Generally the package seems to be aligned with the packaging guidelines and I
have not found any issues.

1) rpmlint OK - no errors
Spelling warnings - all referenced words are comonly used in the industry
Warning about download is not relevant - link is ok, spectool was able to
download the source file based on the spec file. Probably some race condition
in my environment + rpmlint.

$rpmlint dnsmap-0.30-1.fc12.i686.rpm dnsmap-debuginfo-0.30-1.fc12.i686.rpm
dnsmap-0.30-1.fc12.src.rpm 

dnsmap.i686: W: spelling-error Summary(en_US) subdomains -> sub domains,
sub-domains, domains
dnsmap.i686: W: spelling-error Summary(en_US) bruteforcer -> Wilberforce,
enforcer, brutishness
dnsmap.i686: W: spelling-error %description -l en_US pentesters -> pen testers,
pen-testers, pent esters
dnsmap.i686: W: spelling-error %description -l en_US subdomains -> sub domains,
sub-domains, domains
dnsmap.i686: W: spelling-error %description -l en_US bruteforcer ->
Wilberforce, enforcer, brutishness
dnsmap.i686: W: spelling-error %description -l en_US wordlist -> word list,
word-list, wordless
dnsmap.i686: W: spelling-error %description -l en_US txt -> text, ext, tit
dnsmap.i686: W: spelling-error %description -l en_US csv -> cs, cs v, CST
dnsmap.src: W: spelling-error Summary(en_US) subdomains -> sub domains,
sub-domains, domains
dnsmap.src: W: spelling-error Summary(en_US) bruteforcer -> Wilberforce,
enforcer, brutishness
dnsmap.src: W: spelling-error %description -l en_US pentesters -> pen testers,
pen-testers, pent esters
dnsmap.src: W: spelling-error %description -l en_US subdomains -> sub domains,
sub-domains, domains
dnsmap.src: W: spelling-error %description -l en_US bruteforcer -> Wilberforce,
enforcer, brutishness
dnsmap.src: W: spelling-error %description -l en_US wordlist -> word list,
word-list, wordless
dnsmap.src: W: spelling-error %description -l en_US txt -> text, ext, tit
dnsmap.src: W: spelling-error %description -l en_US csv -> cs, cs v, CST
dnsmap.src: W: invalid-url Source0:
http://dnsmap.googlecode.com/files/dnsmap-0.30.tar.gz HTTP Error 404: Not Found
3 packages and 0 specfiles checked; 0 errors, 17 warnings.

2) package name OK, specname OK, 
3) license ok - gplv2+ is the license of code, is in spec and attached in
package
6) spec file is legible and consistent in usage of (17) macros and formating
7) package compiled and running on i686 without issues found
code in srpm matches the upstream code - md5sum used for checksum
15) defattr is present, Executable permissions are not explicitly set by spec
file, but they are  explicitly set by the makefile
16) clean section ok

Best regards
Michal Ambroz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.