[Bug 575541] Review Request: xcalc - Scientific Calculator X11 Client

Sun Mar 21 21:22:11 UTC 2010

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=575541

--- Comment #3 from Terje RÃ¸sten <terjeros at phys.ntnu.no> 2010-03-21 17:22:08 EDT ---
ok rpmlint
ok spec
ok naming
ok perms, dirs and owns
 ? might add INSTALL="install -p" to make install to preserve timestamps  
ok desktop file
 ? license: math.c seems to have a interesting history, is it really BSD?
 ! build flags seems ok, however add V=1 to make to see options
ok sha1sum xcalc-1.0.3.tar.bz2*
    0871efa12f0b28228457b898c3487bc8723d1ea8  xcalc-1.0.3.tar.bz2
    0871efa12f0b28228457b898c3487bc8723d1ea8  xcalc-1.0.3.tar.bz2.spec
 ! is references to TI-30 or an HP-10C ok? HP trademarks?
ok koji
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2066914

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.