[Bug 572511] Review Request: mythes - thesaurus library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=572511

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2010-03-22 00:14:51 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2067174
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
025d5d0d566a23ddb353495c116116c1088ba2e9  mythes-1.2.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ mythes.pc file present.
+ -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package  mythes-1.2.0-1.fc14.i686 =>
Provides: libmythes-1.2.so.0
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4)
libgcc_s.so.1 libm.so.6 libmythes-1.2.so.0 libstdc++.so.6
libstdc++.so.6(CXXABI_1.3) rtld(GNU_HASH)
+ Package mythes-devel-1.2.0-1.fc14.i686 =>
Provides: pkgconfig(mythes) = 1.2.0
Requires: /usr/bin/perl /usr/bin/pkg-config libmythes-1.2.so.0

+ Not a GUI application

Suggestions:
1) I think you need to change existing mythes-* spec files to remove ownership
of /usr/share/mythes from them and let this package alone owns it.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.