[Bug 545720] Review Request: googsystray - A system tray application for accessing various (online) Google apps

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=545720

--- Comment #18 from Leon Keijser <keijser at stone-it.com> 2010-03-22 15:50:03 EDT ---
(In reply to comment #17)
> - python-sitelib, python_sitearch macro are now automatically defined in F13,
> so the first line of the spec should be:

-snip-

Gotcha. I'll modify the spec accordingly.

> - You should remove manually the gXlib dir in %prep section, after patching, as
> an additional security measure to be sure that it's gone at build/exec time

Hm. I don't see the extra benefit of removing the directory, since setup.py
won't include it in the build anyway. And it's not in the %files section, so if
setup.py will change at some point in the future, the files don't get included
anyway. But i guess that apart from the warning from rpmlint (dangerous cmd),
it won't do any harm in removing the gXlib dir in %prep. 

> I don't know why rpm does not pick up automatically python-xlib. Maybe Peter
> knows if we are missing something here.

I'll post a msg to the list, to see if someone else has some insight. It's been
3 months since i first posted this review request, and Peter could be busy with
other things.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.