[Bug 573151] Review Request: python26 - Parallel-installable Python 2.6 for EPEL5

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573151

--- Comment #18 from Dave Malcolm <dmalcolm at redhat.com> 2010-03-22 21:14:52 EDT ---
Sorry about the delay.

2.6.5 was released on Friday, so I've bumped the version to this.

(In reply to comment #16)
> Changing
> install %{SOURCE5} %{buildroot}%{_sysconfdir}/rpm/macros.python26
> to
> install -p -m 644 %{SOURCE5} %{buildroot}%{_sysconfdir}/rpm/macros.python26
> 
> will remove the  
> python26.i386: E: script-without-shebang /etc/rpm/macros.python26    

Thanks!  I've made this change.

The comment from patch 15 contained some whitespace cleanup, which I'd prefer
not to apply: I'm trying to keep this specfile as in-sync as possible with the
Fedora python specfile
The other aspects I applied in order to reduce the noise from rpmlint, although
they're all in the %if %{main_python} section, which should always be false
(again, I'm trying to keep this in-sync with the Fedora specfile); I changed
the "< 2.6.4" to "< 2.6.5"

As for patch 101, it's from the Fedora specfile, and merely adds a new selftest
for http://bugs.python.org/issue931848
python26.spec: W: %ifarch-applied-patch Patch101:
python-2.3.4-lib64-regex.patch

I did some archaeology here; looking at the internal RH CVS server this patch
used to do more for the first day of its existance 2004-05-7, but the rest of
it went upstream as part of what became http://bugs.python.org/issue931848 a
day later, and hasn't needed to be arch specific in that time, I believe.

So I've made 101 not be arch-specific.


New specfile:
http://dmalcolm.fedorapeople.org/epel-packaging/python26.spec

Diff from last SRPM:
http://dmalcolm.fedorapeople.org/epel-packaging/from-python26-2.6.4-23-to-2.6.5-1.diff

New SRPM:
http://dmalcolm.fedorapeople.org/epel-packaging/python26-2.6.5-1.el5.src.rpm

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2068956

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.