[Bug 564567] Review Request: gwaei - A Japanese dictionary for Gnome

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564567

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?

--- Comment #19 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-03-23 13:24:00 EDT ---
Well, for 1.3.0-1

* SourceURL
  - For sourceforge hosted tarball, please follow
    https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

* BR
  - Check if "BR: gettext-devel" is really needed.

* autotool called automatically
  - build.log shows:
-----------------------------------------------------------------
    44  + ./configure --build=i386-redhat-linux-gnu
--host=i386-redhat-linux-gnu --program-prefix= --disable-dependency-tracking
--prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin
--sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include
--libdir=/usr/lib --libexecdir=/usr/libexec --localstatedir=/var
--sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info
--disable-schemas-install
   125  + make -j4
   603  Making all in help
   604  make[2]: Entering directory `/builddir/build/BUILD/gwaei-1.3.0/help'
   605   cd .. && /bin/sh /builddir/build/BUILD/gwaei-1.3.0/missing --run
automake-1.10 --gnu  help/Makefile
   606  /builddir/build/BUILD/gwaei-1.3.0/missing: line 54: automake-1.10:
command not found
   607  WARNING: `automake-1.10' is missing on your system.  You should only
need it if
   608           you modified `Makefile.am', `acinclude.m4' or `configure.ac'.
   609           You might want to install the `Automake' and `Perl' packages.
   610           Grab them from any GNU archive site.
   611   cd .. && /bin/sh ./config.status help/Makefile 
   612  config.status: creating help/Makefile
-----------------------------------------------------------------
    Here automake is called after configure/make. autotools should be
    already executed before configure and automatical call of
    autotools should be avoided.
    Usually timestamps on some files are wrong (or maybe autotools
    were not called correctly before the tarball was packaged).
    Please fix this.

* Scriptlets
  - GConf2 scriptlets are updated (changed):
    https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf
    ! Note
      "BuildRequires: GConf2" is needed to make use of %gconf related
      macros

  - GTK related scriptlets has some mistakes
    ( note that there is no %preun scriptlets for GTK cache, instead
      some scriptlets are %postun scriptlets )
    https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

* Documents
  - We install document files under %_defaultdocdir/%name-%version,
    so please consider to move document files to this directory
  - Also installing "AUTHORS" file is recommended.
  - Files / directories under %_defaultdocdir are automatically marked
    as %doc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.