[Bug 575466] Review Request: gtk-aurora-engine - Aurora GTK+ theme engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=575466

--- Comment #6 from Rahul Sundaram <metherid at gmail.com> 2010-03-23 13:28:27 EDT ---
I am not a sponsor for let me do a quick informal review:

You don't need to define a buildroot or remove the buildroot in the %install
section anymore. So feel free to drop

BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

and  

%__rm -rf %{buildroot}

Macros for common commands such as mkdir and cp are not recommend and just
clutter the spec.

Every single c source file in the first tarball should have a header with the
copyright notice. Merely dropping COPYING in a tarball is not sufficient. 
Please clarify this with upstream. 

INSTALL file can be dropped from the package. It serves no purpose.

When you change the spec, bump up the release and post a new spec and srpm link

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.