[Bug 569582] Review Request: udev-browse - Udev browser tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=569582

--- Comment #3 from Kalev Lember <kalev at smartlink.ee> 2010-03-23 17:51:41 EDT ---
(In reply to comment #2)
> Sorry, but from my point of view, it make no sense to copmile the source code
> into C only to get source files for the debuginfo package.

Debuginfo subpackages isn't the only reason for $RPM_OPT_FLAGS: they also turn
on security features (-fstack-protector --param=ssp-buffer-size=4,
-D_FORTIFY_SOURCE=2), enable specific compiler optimization flags (-O2,
-mtune=atom, -fasynchronous-unwind-tables), and more.


> /.../ it make no sense to copmile the source code into C only to /.../

That's exactly what vala compiler always does: compiles vala code into C. After
generating the C code, it also executes the C compiler. What I was suggesting
was to stop vala from running the C compiler, so that it would be possible for
the build scripts to 1) run vala compiler to produce C code, 2) call the C
compiler with our preferred $RPM_OPT_FLAGS.

>From my point of view, honouring $RPM_OPT_FLAGS is a MUSTFIX.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.