[Bug 577202] Review Request: python-pycha - A library for drawing charts with Python and Cairo

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577202

--- Comment #3 from Ionuț Arțăriși <mapleoin at lavabit.com> 2010-03-27 07:23:33 EDT ---
Thanks a lot for your review!

> - the license is LGPLv3+ because the licensing header contains the "or any
> later vesion" part

fixed

> - is BR: python-devel really required? Only modules with C code should need it.

yeah, AFAIK it's required as per:
https://fedoraproject.org/wiki/Packaging:Python#BuildRequires
It also fails to build without it:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2078411

I changed it to python2-devel instead of python-devel though.

> - rpmlint complains a bit:
> chavier.noarch: W: spelling-error Summary(en_US) pycha -> psych, Pynchon,
> Psyche
> chavier.noarch: W: summary-not-capitalized C a GUI application for exploring
> the pycha library
>     => I would even shorten it to "Application for exploring the pycha library"
I changed it to "GUI application for exploring the pycha library". I feel that
the fact that it has a GUI is important.

> chavier.noarch: W: spelling-error %description -l en_US datasets -> data sets,
> data-sets, databases
>     => should be fixed

fixed

> chavier.noarch: W: spelling-error %description -l en_US pycha -> psych,
> Pynchon, Psyche
> chavier.noarch: W: no-documentation
>     => the "pycha" check can be ignored
> - pycairo must be set as Requires, it is imported by few files in the pycha
> module

fixed

> - I would not include the tests as %doc, examples should be enough

removed tests

* Sat Mar 27 2010 Ionuț C. Arțăriși <mapleoin at fedoraproject.org> - 0.5.2-2
- changed license from LGPLv3 to LGPLv3+
- fixed spelling error in %%description
- capitalized chavier package %%summary
- added pycairo Requires
- removed tests

http://mapleoin.fedorapeople.org/pkgs/python-pycha/python-pycha.spec
http://mapleoin.fedorapeople.org/pkgs/python-pycha/python-pycha-0.5.2-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.