[Bug 573151] Review Request: python26 - Parallel-installable Python 2.6 for EPEL5

bugzilla at redhat.com bugzilla at redhat.com
Sat Mar 27 22:11:53 UTC 2010 

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573151

--- Comment #21 from Kevin Fenzi <kevin at tummy.com> 2010-03-27 18:11:49 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (python)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
6bef0417e71a1a1737ccf5750420fdb3  Python-2.6.5.tar.bz2
6bef0417e71a1a1737ccf5750420fdb3  Python-2.6.5.tar.bz2.orig

OK - BuildRequires correct
See below - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Doc subpackage needed/used. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Headers/static libs in -devel subpackage. 
OK - Spec has needed ldconfig in post and postun
OK - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}

OK - Package compiles and builds on at least one arch. 
See below - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
 - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should function as described. 
OK - Should have sane scriptlets. 
OK - Should have subpackages require base package with fully versioned depend. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Notes: 

This is a long and complex spec, but it's very readable. :) 
I really appreciate the patches descriptions in particular. 

Issues/comments: 

1. It there any value in running some of the tests shipped in python26-test at
build 
time in %test? Or are those more standalone testing framework files?
(They look like they might be unit tests, but not sure how easily they would be
run)

2. Looks like there are some files listed twice?

warning: File listed twice: /usr/lib/python2.6/config/Setup
warning: File listed twice: /usr/lib/python2.6/config/Setup.config
warning: File listed twice: /usr/lib/python2.6/config/Setup.local
warning: File listed twice: /usr/lib/python2.6/config/config.c
warning: File listed twice: /usr/lib/python2.6/config/config.c.in
warning: File listed twice: /usr/lib/python2.6/config/install-sh
warning: File listed twice: /usr/lib/python2.6/config/libpython2.6.so
warning: File listed twice: /usr/lib/python2.6/config/makesetup
warning: File listed twice: /usr/lib/python2.6/config/python.o

3. Does the %{?_isa} dep with the devel package work in el5? 
I think RHEL5 rpm is basically just ignoring this: 

rpm -qp python26-devel-2.6.5-1.el5.x86_64.rpm --requires
python26 = 2.6.5-1.el5

4. rpmlint says a lot of things. Most of which can be ignored. 

Ignore/non blocker: 

python26.src: W: strange-permission pythondeps.sh 0775L
python26.src:728: E: hardcoded-library-path in
%{buildroot}/usr/lib/python%{pybasever}/site-packages
python26.src:787: E: hardcoded-library-path in %{_prefix}/lib/debug/%{_libdir}
python26.src:956: E: hardcoded-library-path in
%{_prefix}/lib/python%{pybasever}
python26.src:957: E: hardcoded-library-path in
%{_prefix}/lib/python%{pybasever}/site-packages
python26.src:181: W: mixed-use-of-spaces-and-tabs (spaces: line 181, tab: line
159)
python26.src: W: invalid-url Source1:
libpython-36a517ef7848cbd0b3dcc7371f32e47ac4c87eba.tar.gz

I suppose these should be 755? 

python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_ssl.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/grpmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_md5module.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/timemodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_csv.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/dlmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/cStringIO.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/termios.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/binascii.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/mathmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/zlibmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_shamodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_codecs_cn.so 0555L
python26.x86_64: W: devel-file-in-non-devel-package
/usr/include/python2.6/pyconfig-64.h
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_bsddb.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/nismodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_collectionsmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/imageop.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/linuxaudiodev.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/operator.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_weakref.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_sha256module.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/fcntlmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/mmapmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/cPickle.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/stropmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_bisectmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/audioop.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_socketmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/spwdmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/cmathmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/gdbmmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_codecs_iso2022.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_codecs_kr.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_multibytecodecmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/selectmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/resource.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_localemodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_codecs_hk.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_codecs_jp.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/cryptmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/timingmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_struct.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/parsermodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_codecs_tw.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/xxsubtype.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/itertoolsmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/unicodedata.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/readline.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_randommodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_functoolsmodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/arraymodule.so 0555L
python26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_sha512module.so 0555L
python26-libs.x86_64: W: spelling-error Summary(en_US) runtime -> run time,
run-time, untimely
python26-libs.x86_64: E: non-standard-executable-perm
/usr/lib64/libpython2.6.so.1.0 0555L
python26-test.x86_64: W: spelling-error %description -l en_US unittest -> unit
test, unit-test, unattested
python26-test.x86_64: W: spelling-error %description -l en_US py -> pt, p, y
python26-test.x86_64: W: no-documentation
python26-test.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_testcapimodule.so 0555L
python26-test.x86_64: E: zero-length /usr/lib64/python2.6/test/nullcert.pem
python26-test.x86_64: W: uncompressed-zip /usr/lib64/python2.6/test/zipdir.zip
python26-tools.x86_64: W: spelling-error %description -l en_US gettext -> get
text, get-text, getting
python26-tools.x86_64: W: spelling-error %description -l en_US pygettext ->
hypertext, Bridgette, courgette
python26-tools.x86_64: W: spelling-error %description -l en_US py -> pt, p, y

chmod these to 644 ?

python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/filebox.xbm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Tools/README
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/combobox.xpm.1
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/scripts/newslist.doc
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/centerj.xbm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/netw.xpm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/optmenu.xpm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/netw.xbm
python26-tools.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.6/Demo/embed/demo.c
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/select.xpm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/bold.xbm
python26-tools.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.6/Demo/embed/importexc.c
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/leftj.xbm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/about.xpm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/capital.xbm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/comparisons/patterns
python26-tools.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.6/Demo/embed/loop.c
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/italic.xbm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/exit.xpm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/combobox.xpm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/underline.xbm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/combobox.xbm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/md5test/foo
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/justify.xbm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/rightj.xbm
python26-tools.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.6/Demo/pysvr/pysvr.c
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/drivea.xpm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/rpc/test
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/drivea.xbm
python26-tools.x86_64: E: script-without-shebang
/usr/lib64/python2.6/Demo/tix/bitmaps/filebox.xpm
tkinter26.x86_64: W: spelling-error %description -l en_US tkinter -> painter,
pointer, printer
tkinter26.x86_64: W: no-documentation
tkinter26.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/lib-dynload/_tkinter.so 0555L

Should be %config(noreplace) ?

python26.x86_64: W: non-conffile-in-etc /etc/rpm/macros.python26

Nothing too outstanding there... might be good to fix some permissions 
though if you have a chance.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

More information about the package-review mailing list