[Bug 573448] Review request: TinyCDB

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573448

--- Comment #3 from Martin Gieseking <martin.gieseking at uos.de> 2010-03-28 06:44:26 EDT ---
(In reply to comment #2)
> I didn't increment the release number, should have I done it ?

Hi Adrien,

yes, you should bump the release number every time you offer a new/different
spec file. It doesn't matter what kind of changes have been made. Otherwise it
could become confusing if several reviewers downloaded and comment on different
versions of the same release.

I had a closer look at the package and there are still some things to do:

- First of all, put the file libcdb.so.1 back to the base package. Only the
symlink libcdb.so should go to devel.

- You must ensure that CFLAGS is set to %{optflags} during the build process.
In the Makefile delete line CFLAGS = -O, and add CFLAGS="%{optflags}" to the
"make" lines in the %build section

- I suggest to create a single patch for the Makefile instead of splitting it
in two parts.

- All binaries should be linked against shared libraries if possible, and
shouldn't use the static variants. Fortunately, the Makefile contains a rule to
build cdb-shared, which we could rename to cdb. 
Thus, change the %build section to (long lines clipped here):
  make %{?_smp_mflags} PREFIX="%{_prefix}" ...
  make shared %{?_smp_mflags} PREFIX="%{_prefix}"  ...
  mv cdb-shared cdb

- Finally, always check your RPMs with rpmlint in order to find potential
problems. After applying the above changes, I get only spelling warnings that
could be ignored:

$ rpmlint /var/lib/mock/fedora-12-x86_64/result/*.rpm
tinycdb.src: W: spelling-error %description -l en_US cdb -> db, cab, cob
tinycdb.src: W: spelling-error %description -l en_US passwd -> passed
tinycdb.src: W: spelling-error %description -l en_US gdbm -> DBMS, Gd, GDP
tinycdb.src: W: spelling-error %description -l en_US dbm -> db, dim, dam
tinycdb.src: W: spelling-error %description -l en_US ndbm -> DBMS, Nd, numb
tinycdb.src: W: spelling-error %description -l en_US runtime -> run time,
run-time, untimely
tinycdb.x86_64: W: spelling-error %description -l en_US passwd -> passed
tinycdb.x86_64: W: spelling-error %description -l en_US gdbm -> DBMS, Gd, GDP
tinycdb.x86_64: W: spelling-error %description -l en_US dbm -> db, dim, dam
tinycdb.x86_64: W: spelling-error %description -l en_US ndbm -> DBMS, Nd, numb
tinycdb.x86_64: W: spelling-error %description -l en_US runtime -> run time,
run-time, untimely
tinycdb-devel.x86_64: W: spelling-error %description -l en_US cdb -> db, cab,
cob
tinycdb-devel.x86_64: W: spelling-error %description -l en_US passwd -> passed
tinycdb-devel.x86_64: W: spelling-error %description -l en_US gdbm -> DBMS, Gd,
GDP
tinycdb-devel.x86_64: W: spelling-error %description -l en_US dbm -> db, dim,
dam
tinycdb-devel.x86_64: W: spelling-error %description -l en_US ndbm -> DBMS, Nd,
numb
tinycdb-devel.x86_64: W: spelling-error %description -l en_US runtime -> run
time, run-time, untimely
tinycdb-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 18 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.