[Bug 567094] Review Request: mumble - Voice chat suite aimed at gamers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567094

--- Comment #9 from Thomas Kowaliczek <linuxdonald at linuxdonald.de> 2010-03-28 10:27:20 EDT ---
On this things i need answers.


MUST: rpmlint must be run on every package. The output should be posted in the
review.

[LinuxDonald at localhost x86_64]$ rpmlint *.rpm
mumble.x86_64: W: spelling-error Summary(en_US) gamers -> gamer, games, tamers
mumble.x86_64: W: spelling-error %description -l en_US gamers -> gamer, games,
tamers
mumble-overlay.x86_64: W: spelling-error %description -l en_US gamers -> gamer,
games, tamers
mumble-overlay.x86_64: W: spelling-error %description -l en_US ingame -> in
game, in-game, Ingram
mumble-overlay.x86_64: W: no-documentation
mumble-overlay.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/mumble/libmumble.so
mumble-plugins.x86_64: W: spelling-error %description -l en_US gamers -> gamer,
games, tamers
mumble-plugins.x86_64: W: spelling-error %description -l en_US plugin -> plug
in, plug-in, plugging
mumble-plugins.x86_64: W: no-documentation
mumble-protocol.x86_64: W: spelling-error %description -l en_US gamers ->
gamer, games, tamers
mumble-protocol.x86_64: W: no-documentation
murmur.x86_64: W: spelling-error %description -l en_US gamers -> gamer, games,
tamers
murmur.x86_64: W: non-conffile-in-etc /etc/logrotate.d/murmur
murmur.x86_64: W: non-standard-uid /etc/rc.d/init.d/murmur mumble-server
murmur.x86_64: W: non-standard-gid /etc/rc.d/init.d/murmur mumble-server
murmur.x86_64: W: non-standard-uid /etc/murmur/murmur.ini mumble-server
murmur.x86_64: W: non-standard-gid /etc/murmur/murmur.ini mumble-server
murmur.x86_64: W: non-standard-uid /var/log/mumble-server mumble-server
murmur.x86_64: W: non-standard-gid /var/log/mumble-server mumble-server
murmur.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/murmur.conf
murmur.x86_64: W: non-standard-uid /etc/mumble-server.ini mumble-server
murmur.x86_64: W: non-standard-gid /etc/mumble-server.ini mumble-server
murmur.x86_64: W: non-standard-uid /var/run/mumble-server mumble-server
murmur.x86_64: W: non-standard-gid /var/run/mumble-server mumble-server
murmur.x86_64: W: non-standard-uid /usr/sbin/murmurd mumble-server
murmur.x86_64: W: non-standard-gid /usr/sbin/murmurd mumble-server
murmur.x86_64: W: non-standard-uid /var/lib/mumble-server mumble-server
murmur.x86_64: W: non-standard-gid /var/lib/mumble-server mumble-server
6 packages and 0 specfiles checked; 0 errors, 28 warnings.

MUST: The spec file must be written in American English.
See in above

MUST: Packages must NOT bundle copies of system libraries.
What abou celt and speex in the tarball?

MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
What about libmumble.so in mumble-overlay package?
and the .so files in mumble-plugins?
Is that okay?

MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
Okay (is that correct here: #install desktop file for mumble-overlay
#desktop-file-install --dir=%{buildroot}%{_datadir}/applications \
#%{SOURCE3}

@Packager

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.