[Bug 564567] Review Request: gwaei - A Japanese dictionary for Gnome

Sun Mar 28 14:28:28 UTC 2010

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=564567

--- Comment #20 from René Ribaud <rene.ribaud at free.fr> 2010-03-28 10:28:21 EDT ---
(In reply to comment #19)

Hello Mamoru,

Thanks for the previous review.
I have made a new package hoping it will correct all previous pitfalls.

Please look at my comments below :

> Well, for 1.3.0-1
> 
> * SourceURL
>   - For sourceforge hosted tarball, please follow
>     https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

Gwaei binary package URL is :
http://downloads.sourceforge.net/project/gwaei/gwaei/1.3.0/gwaei-1.3.0.tar.gz

As you can see upstream doesn't respect Fedora' spec :
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
for any reason.

So I have kept the real link inside the spec file.

Should I request a change upstream to fix this ?

> 
> * BR
>   - Check if "BR: gettext-devel" is really needed.
> 

Yes it is required by automake.

> * autotool called automatically
>   - build.log shows:
> -----------------------------------------------------------------
>     44  + ./configure --build=i386-redhat-linux-gnu
> --host=i386-redhat-linux-gnu --program-prefix= --disable-dependency-tracking
> --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin
> --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include
> --libdir=/usr/lib --libexecdir=/usr/libexec --localstatedir=/var
> --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info
> --disable-schemas-install
>    125  + make -j4
>    603  Making all in help
>    604  make[2]: Entering directory `/builddir/build/BUILD/gwaei-1.3.0/help'
>    605   cd .. && /bin/sh /builddir/build/BUILD/gwaei-1.3.0/missing --run
> automake-1.10 --gnu  help/Makefile
>    606  /builddir/build/BUILD/gwaei-1.3.0/missing: line 54: automake-1.10:
> command not found
>    607  WARNING: `automake-1.10' is missing on your system.  You should only
> need it if
>    608           you modified `Makefile.am', `acinclude.m4' or `configure.ac'.
>    609           You might want to install the `Automake' and `Perl' packages.
>    610           Grab them from any GNU archive site.
>    611   cd .. && /bin/sh ./config.status help/Makefile 
>    612  config.status: creating help/Makefile
> -----------------------------------------------------------------
>     Here automake is called after configure/make. autotools should be
>     already executed before configure and automatical call of
>     autotools should be avoided.
>     Usually timestamps on some files are wrong (or maybe autotools
>     were not called correctly before the tarball was packaged).
>     Please fix this.
> 

I have fixed this adding autogen.sh (coming from gwaei's git) that will do the
required aclocal, auto* ... commands.

Although, the warning you mentioned disappeared, I'm not sure this is the best
way to do it. Advices on this point are welcomed.

> * Scriptlets
>   - GConf2 scriptlets are updated (changed):
>     https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf
>     ! Note
>       "BuildRequires: GConf2" is needed to make use of %gconf related
>       macros
> 

Thanks for the notification, I didn't realized it changed.
Fix done.

>   - GTK related scriptlets has some mistakes
>     ( note that there is no %preun scriptlets for GTK cache, instead
>       some scriptlets are %postun scriptlets )
>     https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
> 

Fix done too.

> * Documents
>   - We install document files under %_defaultdocdir/%name-%version,
>     so please consider to move document files to this directory
>   - Also installing "AUTHORS" file is recommended.
>   - Files / directories under %_defaultdocdir are automatically marked
>     as %doc.    

Unified into /usr/share/doc/gwaei-1.3.0
I have added AUTHORS and THANKS files.

You will be able to find the new package here :

Spec URL: http://uggla.free.fr/rpmbuild/SPECS/gwaei.spec
SRPM URL: http://uggla.free.fr/rpmbuild/SRPMS/12/gwaei-1.3.0-2.fc12.src.rpm

RPMLINT output :
----------------
[ctb at uggla x86_64]$ rpmlint gwaei-1.3.0-2.fc12.x86_64.rpm
gwaei.x86_64: W: spelling-error %description -l en_US kanji -> Kantian, Kanpur,
Kansas
gwaei.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gwaei.schemas
gwaei.x86_64: W: dangerous-command-in-%pre rm
gwaei.x86_64: W: dangerous-command-in-%post rm
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

[ctb at uggla SRPMS]$ rpmlint gwaei-1.3.0-2.fc12.src.rpm 
gwaei.src: W: spelling-error %description -l en_US kanji -> Kantian, Kanpur,
Kansas
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

KOJI output :
-------------

I have built the package with koji on all architectures for F12, F13 and
rawhide.
You can look at the F12 result here :
http://koji.fedoraproject.org/koji/taskinfo?taskID=2079390

F13 here :
http://koji.fedoraproject.org/koji/taskinfo?taskID=2079399

and F14 here :
http://koji.fedoraproject.org/koji/taskinfo?taskID=2079410

Waiting for your feedbacks.

Best regards.
René

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.