[Bug 576469] Review Request: rubygem-mixlib-authentication - Simple per-request authentication

bugzilla at redhat.com bugzilla at redhat.com
Mon Mar 29 08:10:27 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=576469

--- Comment #2 from Matthew Kent <mkent at magoazul.com> 2010-03-29 04:10:24 EDT ---
Thanks for the review!

(In reply to comment #1)
> Some notes:
> 
> * Duplicate file entry
>   - %{geminstdir}/Rakefile is packaged in both main and -doc package.
> 

Oops, thanks!

> * %check
>   - You seem to recover "rake spec" failure by "|| true", however
>     what test failure are you seeing?    

Apologies - believe that's a remnant from testing. Just tested that it builds
fine on F-13, will build okay on F-11/F-12 when the other mixlib updates I
submitted are pushed.

Spec URL: http://magoazul.com/wip/SPECS/rubygem-mixlib-authentication.spec
SRPM URL:
http://magoazul.com/wip/SRPMS/rubygem-mixlib-authentication-1.1.2-2.fc14.src.rpm

* Mon Mar 19 2010 Matthew Kent <matt at bravenet.com> - 1.1.2-2
- Let check phase fail.
- Fix duplicate inclusion of Rakefile.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list