[Bug 549366] Review Request: flaw - Small multiplayer action game

bugzilla at redhat.com bugzilla at redhat.com
Mon Mar 29 09:13:25 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=549366

--- Comment #19 from Andrea Musuruane <musuruan at gmail.com> 2010-03-29 05:13:22 EDT ---
You are still mixing macro styles. Please change the following line from:

desktop-file-validate %{buildroot}/%{_datadir}/applications/%{name}.desktop

to:
desktop-file-validate $RPM_BUILD_ROOT%{_datadir}/applications/%{name}.desktop

Also note that both $RPM_BUILD_ROOT and %{buildroot} already have the tailing
slash therefore there is no need to add it. You can check this with:

rpm --eval %{buildroot}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list