[Bug 576431] Package Review: skipfish - Web application security scanner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=576431

--- Comment #6 from Michal Ambroz <rebus at seznam.cz> 2010-03-29 08:24:35 EDT ---
SPEC URL: http://rebus.webz.cz/d/skipfish.spec
SRPM URL: http://rebus.webz.cz/d/skipfish-1.26-0.2.b.fc12.src.rpm    

Hello Martin,
thank you for the review.

>- you can drop "%attr(755,root,root)" from the %files section because the
>permissions are set automatically
Done

>- Directory /usr/share/skipfish/assets contains a file COPYING with the GPL 3.0
>license text. 
Thanks for noticing that. License is actually LGPLv3. 

>You should ask upstream whether the images are actually intended
>to be licensed under GPLv3.
>If so, change the License tag to "ASL 2.0 and GPLv3".
Icons are comming from different project so they need to keep different
license.
Following the licensing guideline I have split skipfish to 2 packages with
different licenses
(http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Multiple_Licensing_Scenarios)

>- Please also upload the SPEC file to your server. 
> The above SPEC URLs don't work (404).    
I a sorry for the typo ... it should have been .spec not .SPEC

Best regards
Michal Ambroz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.