[Bug 225743] Merge Review: expect

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225743

--- Comment #11 from Vitezslav Crhonek <vcrhonek at redhat.com> 2010-03-29 11:10:26 EDT ---
(In reply to comment #8)
[snip]
> 
> BAD debuginfo package looks complete. - rpmlint warns
> expect-debuginfo.i386: W: spurious-executable-perm
> /usr/src/debug/expect-5.43/exp_main_tk.c
> (maybe that is nothing to worry about, let's see your comments)

Honestly, don't know why it's executable. Permissions are preserved from
upstream.

> 
> BAD rpmlint is silent.
>   W: patch-not-applied Patch7: expect-5.43.0-tcl8.5.6.patch
>   (this minor warning can be easily corrected)

Fixed.

> 
> OK final provides and requires look sane.
> OK %check is present and all tests pass.
> 
> BAD shared libraries should be added to the regular linker search paths.
> every binary RPM package which contains shared library files (not just
> symlinks) in any of the dynamic linker's default paths, must call ldconfig in
> %post and %postun.
> -there's /usr/lib/libexpect5.43.so and no call to /sbin/ldconfig 
> 

I think that this library is used by Tcl only, which knows the path to the
library from /usr/lib64/tcl8.5/expect5.43/pkgIndex.tcl file.

[snip]

FYI, there's new version in devel branch...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.