[Bug 564567] Review Request: gwaei - A Japanese dictionary for Gnome

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564567

--- Comment #21 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-03-29 14:56:53 EDT ---
Created an attachment (id=403340)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=403340)
Patch to kill autotool call for help/Makefile.am

For -2:

* SourceURL

(In reply to comment #20)
> (In reply to comment #19)
> >   - For sourceforge hosted tarball, please follow
> >     https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
> As you can see upstream doesn't respect Fedora' spec :
> http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
> for any reason.

----------------------------------------------------------------
$ env LANG=C wget -N http://downloads.sourceforge.net/gwaei/gwaei-1.3.0.tar.gz
--2010-03-30 01:15:34-- 
http://downloads.sourceforge.net/gwaei/gwaei-1.3.0.tar.gz
Resolving downloads.sourceforge.net... 216.34.181.59
Connecting to downloads.sourceforge.net|216.34.181.59|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location:
http://jaist.dl.sourceforge.net/project/gwaei/gwaei/1.3.0/gwaei-1.3.0.tar.gz
[following]
--2010-03-30 01:15:34-- 
http://jaist.dl.sourceforge.net/project/gwaei/gwaei/1.3.0/gwaei-1.3.0.tar.gz
Resolving jaist.dl.sourceforge.net... 150.65.7.130
Connecting to jaist.dl.sourceforge.net|150.65.7.130|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 675297 (659K) [application/x-gzip]
Saving to: `gwaei-1.3.0.tar.gz'

100%[====================================================================================================>]
675,297     --.-K/s   in 0.1s    

2010-03-30 01:15:34 (6.20 MB/s) - `gwaei-1.3.0.tar.gz' saved [675297/675297]

----------------------------------------------------------------
  - So the URL recommended by Fedora seems to be working.

* autogen.sh
  - If this is needed, it is more readable to add autogen.sh as SourceX
    and copy it to build directory, rather than to create a patch which
    generates autogen.sh.
  - It is recommended to call autogen.sh in %prep, rather than in %build.


* automated autotool call

> > * autotool called automatically
> >     Here automake is called after configure/make. autotools should be
> >     already executed before configure and automatical call of
> >     autotools should be avoided.
> >     Usually timestamps on some files are wrong (or maybe autotools
> >     were not called correctly before the tarball was packaged).
> >     Please fix this.
> 
> I have fixed this adding autogen.sh (coming from gwaei's git) that will do the
> required aclocal, auto* ... commands.
> 
> Although, the warning you mentioned disappeared, I'm not sure this is the best
> way to do it. Advices on this point are welcomed.

  - Still aututools are called automatically:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2081887
---------------------------------------------------------------------
   326  + make -j4
   327  (CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh
/builddir/build/BUILD/gwaei-1.3.0/missing --run autoheader)
   328  rm -f stamp-h1
   329  touch config.h.in
   809  Making all in help
   810  make[2]: Entering directory `/builddir/build/BUILD/gwaei-1.3.0/help'
   811   cd .. && /bin/sh /builddir/build/BUILD/gwaei-1.3.0/missing --run
automake-1.11 --gnu help/Makefile
  1003   cd .. && /bin/sh ./config.status help/Makefile 
  1004  config.status: creating help/Makefile
---------------------------------------------------------------------
    So config.h.in and help/Makefile.am or so are not correctly updated.

    ! After some investigation:
      The first one (autoheader being called to regenerate config.h.in) is
      while autogen.sh reads:
---------------------------------------------------------------------
     1 #! /bin/sh
     2 
     3 aclocal \
     4 && gnome-doc-prepare -c -f \
     5 && automake -c -f --add-missing \
     6 && autoconf -f
---------------------------------------------------------------------
      Actually:
---------------------------------------------------------------------
$ gnome-doc-prepare -c -f
Remember to add 'GNOME_DOC_INIT' to configure.ac.
You should update your 'aclocal.m4' by running aclocal.
Putting files in AC_CONFIG_MACRO_DIR, 'm4'.
---------------------------------------------------------------------
      So aclocal should be called after gnome-doc-prepare.
      Also "autoheader -f " is actually not called before configure. So
      calling "autoheader -f" should be added to autogen.sh

      The latter one (automake being automatically called to regenerate
help/Makefile.in)
      is due to incorrect handling of help/Makefile.am in configure.ac.

      configure.ac contains:
---------------------------------------------------------------------
   133  if([test x$gnome = xfalse]);then([cp help/Makefile.am.gnome
help/Makefile.am]);fi
   134  if([test x$gnome = xtrue]);then([cp help/Makefile.am.none
help/Makefile.am]);fi
---------------------------------------------------------------------
      This makes help/Makefile.am renewed during configure process.
      So after configure finished, Makefile.in has to be regenerated from
      renewed help/Makefile.am and autotools are recalled.

      So gnome/non-gnome handling in configure.ac|help/Makefile.am must
      be fixed. The attached patch will fix this issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.