[Bug 577932] Review Request: python-geoclue - A Geoclue python module
bugzilla at redhat.com
bugzilla at redhat.com
Mon Mar 29 20:38:06 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=577932
Thomas Spura <tomspur at fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |tomspur at fedoraproject.org
AssignedTo|nobody at fedoraproject.org |tomspur at fedoraproject.org
Flag| |fedora-review+
--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2010-03-29 16:38:05 EDT ---
Review:
Good:
- rpmlint
$ rpmlint ./python-geoclue-0.1.0-1.fc13.src.rpm
noarch/python-geoclue-0.1.0-1.fc13.noarch.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
- group ok
- name ok
(I believe you should directly provide python2-geoclue, because this is likly
to happen in the future.)
- BuildRoot ok
If you don't want to build in RHEL, could you delete that?
- %prep ok
- %build ok
- %install ok
- no libs
- no *.la
- buildarch: noarch ok
Needswork:
- %files
* you should change 0.1.0 to %{version}, this way you don't need to change
this all the time.
* how about %doc docs/* ?
- license wrong: GPLv3 -> GPLv3+
- BR wrong:
* What is pygobject2-devel for?
Please BR pygobjec2 instead (only the python files are needed, not the
whole -devel package).
* Instead you need to also Require pygobject2 for python importing on runtime
############################################
All needswork are easyfixes, ping me if you object to something.
############################################
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list