[Bug 576023] Review Request: libwebcam - user-space configuration of the uvcvideo driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=576023

Germán Racca <gracca at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gracca at gmail.com

--- Comment #1 from Germán Racca <gracca at gmail.com> 2010-03-29 16:54:13 EDT ---
Hello Michael:

Just a few comments based on the rpmlint output (I'm not an official reviewer,
just someone looking for sponsorship):

libwebcam.i686: E: explicit-lib-dependency libxml2
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.
** This means that you must remove Requires: libxml2 **

libwebcam.i686: W: invalid-license LGPL
The value of the License tag was not recognized.  Known values are:
....................
"Giftware", "GL2PS", "Glide", "gnuplot", "GPL+", "GPL+ or Artistic", "GPL+
with exceptions", "GPLv1", "GPLv2 or Artistic", "GPLv2+ or Artistic", "GPLv2",
"GPLv2 with exceptions", "GPLv2+", "GPLv2+ with exceptions", "GPLv3", "GPLv3
with exceptions", "GPLv3+", "GPLv3+ with exceptions", "IBM", "IJG",
"ImageMagick", "iMatix", "Imlib2", "Intel ACPI", "Interbase", "ISC", "Jabber",
"JasPer", "JPython", "Knuth", "LBNL BSD", "LGPLv2", "LGPLv2 with exceptions",
"LGPLv2+", "LGPLv2+ or Artistic", "LGPLv2+ with exceptions", "LGPLv3", "LGPLv3
with exceptions", "LGPLv3+", "LGPLv3+ with exceptions", "libtiff", "LLGPL",
....................
** So, you must choose a different value. According to the source package, this
is LGPLv3+ **

libwebcam.i686: W: one-line-command-in-%post /sbin/ldconfig
You should use %post -p <command> instead of using:  %post <command>  It will
avoid the fork of a shell interpreter to execute your command as well as
allows rpm to automatically mark the dependency on your command for the
excecution of the scriptlet.
** Self explanatory **

libwebcam.i686: W: one-line-command-in-%postun /sbin/ldconfig
You should use %postun -p <command> instead of using:  %postun <command>  It
will avoid the fork of a shell interpreter to execute your command as well as
allows rpm to automatically mark the dependency on your command for the
excecution of the scriptlet.
** Also self explanatory **

Hope this helps you!
Cheers,
Germán.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.