[Bug 573248] Review Request: garden - An innovative old-school 2D vertical shoot-em-up

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573248

--- Comment #2 from Martin Gieseking <martin.gieseking at uos.de> 2010-03-30 14:01:08 EDT ---
Here's the full review. Unfortunately, the package isn't as clean as I thought
initially. :)

- as mentioned above, the License tag must be GPLv3+
- the package doesn't build for F-13 because of a missing LDFLAG
- COPYING is missing in %doc
- just a suggestion: add a trailing slash to %{_datadir}/%{name} in order to
indicate that a folder is added

For further details see the checklist below.

$ rpmlint /var/lib/mock/fedora-12-x86_64/result/*.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.


---------------------------------
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    - GPLv3+ according to source file headers

[X] MUST: The License field in the package spec file must match the actual
license.
    - change GPLv3 to GPLv3+ 

[X] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
    - add COPYING to %doc

[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum garden-1.0.8.tar.gz*
    42966f2c457d71a3ff0dd30522801ade  garden-1.0.8.tar.gz
    42966f2c457d71a3ff0dd30522801ade  garden-1.0.8.tar.gz.1

[X] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    - The package fails building for F-13:
      http://koji.fedoraproject.org/koji/taskinfo?taskID=2084784
    - add automake and autoconf to BR
    - add the following lines to the %prep section (or patch configure.ac
accordingly):
      sed -i '/^AC_CHECK_HEADERS/s/$/\nAC_CHECK_LIB(m, sin)/' configure.ac 
      sed -i '/^AS_INIT/d' configure.ac 
      autoreconf
    - this should be reported upstream

[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly. 
    - no locales

[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files...
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
[.] MUST: If a package contains library files ...
[.] MUST: devel packages must require the base package 
[.] MUST: Packages must NOT contain any .la libtool archives.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
[+] .desktop files must be properly installed with desktop-file-install in the
%install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.
[+] MUST: All filenames in rpm packages must be valid UTF-8.
[+] MUST: Icons must be properly installed.

[+] SHOULD: The reviewer should test that the package builds in mock.
    builds in mock for F-12

[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
    builds in koji for F-12

[+] SHOULD: The reviewer should test that the package functions as described.
    - functions on F-12 (great game :))

[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.