[Bug 567027] Review Request: flowcanvas - Interactive widget for "boxes and lines" environments

Wed Mar 31 14:28:07 UTC 2010

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=567027

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |martin.gieseking at uos.de
         AssignedTo|nobody at fedoraproject.org    |martin.gieseking at uos.de
               Flag|                            |fedora-review+

--- Comment #2 from Martin Gieseking <martin.gieseking at uos.de> 2010-03-31 10:28:03 EDT ---
Here's my review of your package. I couldn't find anything to complain about.
Just a file containing the GPLv2 license text is missing in the tarball. You
should ask upstream to add it in future releases.

$ rpmlint /var/lib/mock/fedora-12-i386/result/flowcanvas-*.rpm
flowcanvas.i686: W: spelling-error %description -l en_US patchers -> patches,
pitchers, catchers
flowcanvas.i686: W: spelling-error %description -l en_US automata -> automate,
automatic, automaton
flowcanvas.src: W: spelling-error %description -l en_US patchers -> patches,
pitchers, catchers
flowcanvas.src: W: spelling-error %description -l en_US automata -> automate,
automatic, automaton
flowcanvas-devel.i686: W: spelling-error %description -l en_US patchers ->
patches, pitchers, catchers
flowcanvas-devel.i686: W: spelling-error %description -l en_US automata ->
automate, automatic, automaton
4 packages and 0 specfiles checked; 0 errors, 6 warnings.

These spelling errors can be ignored.

---------------------------------
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    - GPLv2+ according to source file headers

[+] MUST: The License field in the package spec file must match the actual
license.
[.] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
    - GPLv2 license text is missing in upstream tarball

[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
    $ md5sum flowcanvas-0.6.0.tar.bz2*
    15ffa0d65401bb38a3cc94a3d6afb199  flowcanvas-0.6.0.tar.bz2
    15ffa0d65401bb38a3cc94a3d6afb199  flowcanvas-0.6.0.tar.bz2.1

[+] MUST: The package MUST successfully compile and build 
    - F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2087093
    - F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2087111 

[.] MUST: If the package does not successfully compile, build or work ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[+] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
[+] MUST: .so files without suffix must go in a -devel package.
[+] MUST: devel packages must require the base package using a fully versioned
dependency
[+] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[X] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
    - I successfully built and executed Patchage
(http://drobilla.net/software/patchage) with this library

[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: subpackages other than devel should require the base package using
a fully versioned dependency.
[+] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.

------------------------
The package is APPROVED.
------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.