[Bug 541765] Review Request: NanoEngineer-1 - Nano-composite modeling and simulation program

bugzilla at redhat.com bugzilla at redhat.com
Wed Mar 31 15:44:25 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=541765

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org

--- Comment #16 from Thomas Spura <tomspur at fedoraproject.org> 2010-03-31 11:44:23 EDT ---
(In reply to comment #12)
> Aha, here's a thought -- I'm using the PyQt4 from the kde-redhat repository,
> not from the F12 main repo. Wonder if that has something to do with it ...    

That doesn't matter.

See FlyoutToolbar.py:74:
    def getExtensionButton(self):
        """
        Returns the extension popup indicator toolbutton ">>"
        """

        btn = None
        clist = self.children()

        if len(clist) > 2:
            if isinstance(clist[2], QToolButton):
                btn = clist[2]

        return btn

The clist[2] is none, which is later passed to the function
_setExtensionButtonIcon in line 65.

One solution would be to patch that last function from:
        extension_button = self.getExtensionButton()
        extension_button.setIcon(geticon(
            "ui/actions/Command Toolbar/ExtensionButtonImage.png"))
to:
        extension_button = self.getExtensionButton()
        if extension_button:
            extension_button.setIcon(geticon(
            "ui/actions/Command Toolbar/ExtensionButtonImage.png"))

So there won't be an icon in that case (and maybe breaking something else).
Please test that...
You should query upstream to ask what exactly could break or so...

(I didn't watch anything else at this package, just noticed this because of
Marys' post on the devel list.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list