[Bug 584728] Review Request: rktime - Multi-zone time display utility
bugzilla at redhat.com
bugzilla at redhat.com
Mon May 3 11:03:43 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=584728
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> 2010-05-03 07:03:41 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2157338
+ rpmlint is silent for SRPM and for RPM.
rktime.src: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti
rktime.src: W: spelling-error %description -l en_US timezones -> timezone, time
zones, time-zones
rktime.noarch: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti
rktime.noarch: W: spelling-error %description -l en_US timezones -> timezone,
time zones, time-zones
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
==> Ignore these messages.
+ source files match upstream url (sha1sum)
78e26fd538872ea11b4cf610016128ae0c934d4e rktime-0.6.tgz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list