[Bug 578981] Review Request: libdrizzle - Drizzle Client & Protocol Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578981

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |martin.gieseking at uos.de
               Flag|                            |fedora-review?

--- Comment #6 from Martin Gieseking <martin.gieseking at uos.de> 2010-05-03 09:01:54 EDT ---
Sorry for the delay. Here's the formal review of your package. It's almost
clean. I only found two further things that need to be fixed:

- libdrizzle uses Steve Reid's implementation of SHA1 (sha1.{h,c}) which is in
public domain. Hence, add "and Public Domain" to the Licence field plus a short
comment before it.

- the -doc package should get a fully versioned dependency to the base package,
i.e. add Requires: %{name} = %{version}-%{release}


$ rpmlint /var/lib/mock/fedora-12-i386/result/*.rpm
libdrizzle-devel.i686: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 1 warnings.

The warning can be safely ignored.

---------------------------------
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines
.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[X] MUST: The License field in the package spec file must match the actual
license.

[+] MUST: File containing the text of the license for the package must be
included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum libdrizzle-0.8.tar.gz*
    644ac8b318b2dbae6edbcfabba23ccd5  libdrizzle-0.8.tar.gz
    644ac8b318b2dbae6edbcfabba23ccd5  libdrizzle-0.8.tar.gz.1

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    koji scratch builds:
    F-12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2157557
    F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2157545

[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly. 
[+] MUST: RPM packages which store shared library files must call ldconfig in
%post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[+] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[+] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[+] MUST: .so files with a suffix must go in a -devel package.
[+] MUST: devel packages must require the base package using a fully versioned
dependency.
[+] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications ...
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures. 
[+] SHOULD: All used scriptlets must be sane.
[X] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[+] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.