[Bug 588122] Review Request: perl-Symbol-Util - Additional utilities for Perl symbols manipulation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588122

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> 2010-05-04 03:32:01 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2159902
+ rpmlint output for SRPM and for RPM.
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ source files match upstream url (sha1sum)
5119464d6816ffaf3cb7ecc7c951c53e693745c1  Symbol-Util-0.0202.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=8, Tests=307,  0 wallclock secs ( 0.06 usr  0.02 sys +  0.21 cusr  0.05
csys =  0.34 CPU)
+ Package perl-Symbol-Util-0.0202-2.fc14.noarch =>
Provides: perl(Symbol::Util) = 0.0202
Requires: perl >= 0:5.006 perl(strict) perl(warnings)
+ Not a GUI application

Suggestions:
1) Remove following from SPEC
BuildRequires:  perl

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.