[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588437

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp

--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-05-05 13:40:58 EDT ---
Some notes:

* %define -> %global
  - We now prefer to use %global instead of %define.
   
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

* License
  - is MIT for 

* BuildRoot
  - On Fedora BuildRoot is no longer needed (rpmlint may complain about
    removing this, however you can ignore it)

* abi requirements
  - Writing "Requires: ruby(abi) = 1.8" is mandatory
    https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines

* Test
  - As this gem contains test/ directory, please add %check section and
    execute some tests there (like $ rake test)
  - Also as this gem contains spec/ directory, executing $rake spec
    is preferred.

* Duplicate files
  https://fedoraproject.org/wiki/Packaging/Guidelines#Duplicate_Files
--------------------------------------------------------------------
    57  warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/fakefs-0.2.1/LICENSE
    58  warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/fakefs-0.2.1/README.markdown
--------------------------------------------------------------------
  - Please make it sure that every file is listed only once in %files
    section.

* Consistent macro usage
  - As %geminstdir macro is defined, please use this macro in %files
    consistently.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.