[Bug 587438] Review Request: rubygem-snmp - A Ruby implementation of SNMP (the Simple Network Management Protocol)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=587438

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp

--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-05-06 13:51:27 EDT ---
Some notes:

* Unused macro
  - %ruby_sitelib macro doesn't seem to be used anywhere

* License
  - When the license is "the same as Ruby", it means
    "GPLv2 or Ruby" for license tag.

* %doc
  - Please mark document files as %doc properly
    * "README" file should be marked as %doc
    * examples/ test/ directory should also be marked
      as %doc

* Enabling test
  - As this gem contains test/ directory, please add %check
    section and execute some tests (like $ rake test) there.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.