[Bug 576685] Review Request: pekwm - A small and flexible window manager

bugzilla at redhat.com bugzilla at redhat.com
Sun May 9 16:47:34 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=576685

--- Comment #9 from Christoph Wickert <cwickert at fedoraproject.org> 2010-05-09 12:47:28 EDT ---
Sorry it took so long.

I have no problems sponsoring you, you have done well here and in the other
reviews. However there are still some problems with the package:

drwxr-xr-x  /usr/share/doc/pekwm-0.1.12/contrib
-rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/Makefile
-rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/Makefile.am
-rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/Makefile.in
drwxr-xr-x  /usr/share/doc/pekwm-0.1.12/contrib/lobo
-rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/Makefile
-rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/Makefile.am
-rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/Makefile.in
-rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/README
-rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/check.png
-rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/pekwm_autoprop.pl
-rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/pekwm_menu_config.pl
-rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/pekwm_menu_config.pl.vars
-rw-r--r--  /usr/share/doc/pekwm-0.1.12/contrib/lobo/uncheck.png

As you can see the Makefiles end up in the package. Your options:
1. Remove them in %install
2. Install the the files individually and not the whole contrib folder. Then
you could also nuke the "lobo" subfolder which is useless as long as it is the
only one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list