[Bug 590733] Review Request: bsp - The most popular node builder for Doom

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=590733

--- Comment #5 from Dan Horák <dan at danny.cz> 2010-05-11 04:14:39 EDT ---
formal review is here, see the notes explaining OK* and BAD statuses below:

OK      source files match upstream:
            52af16dfa28c7838d9503a9153d93bfa031ac169  bsp-5.2.tar.bz2
OK      package meets naming and versioning guidelines.
OK      specfile is properly named, is cleanly written and uses macros
consistently.
OK      dist tag is present.
OK      license field matches the actual license.
OK      license is open source-compatible (GPLv2+). License text included in
package.
OK      latest version is being packaged.
OK      BuildRequires are proper.
BAD     compiler flags are appropriate.
OK      %clean is present.
OK      package builds in mock (Rawhide/x86_64).
OK      debuginfo package looks complete.
OK*     rpmlint is silent.
OK      final provides and requires look sane.
N/A     %check is present and all tests pass.
OK      no shared libraries are added to the regular linker search paths.
OK      owns the directories it creates.
OK      doesn't own any directories it shouldn't.
OK      no duplicates in %files.
OK      file permissions are appropriate.
OK      no scriptlets present.
OK      code, not content.
OK      documentation is small, so no -docs subpackage is necessary.
OK      %docs are not necessary for the proper functioning of the package.
OK      no headers.
OK      no pkgconfig files.
OK      no libtool .la droppings.
OK      not a GUI app.

- there is still an issue with the compiler flags, now it mixes the Fedora set
with bsp's own in a not so compatible way, using "make CFLAGS='%{optflags}
%{?_smp_mflags}'" that overrides the bsp's ones completely is in my opinion a
better variant
- rpmlint complains a bit
bsp.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee
bsp.src: W: spelling-error %description -l en_US pre -> per, ore, pee
    => false positive, can be ignored

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.