[Bug 591032] Review Request: R-xtable - Export tables to LaTeX or HTML

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591032

Pierre-YvesChibon <pingou at pingoured.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #3 from Pierre-YvesChibon <pingou at pingoured.fr> 2010-05-12 03:50:47 EDT ---
* source files match upstream:
   sha1sum xtable_1.5-6.tar.gz 
2eb74a6d55c0b38d07180f876ec63ce8fbd77742  xtable_1.5-6.tar.gz
   sha1sum rpmbuild/SOURCES/xtable_1.5-6.tar.gz 
2eb74a6d55c0b38d07180f876ec63ce8fbd77742  rpmbuild/SOURCES/xtable_1.5-6.tar.gz

* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
! BuildRequires are proper.
  You should BR on R-devel rather than R

* %clean is present.
* package builds in koji (
http://koji.fedoraproject.org/koji/taskinfo?taskID=2182035 ).
* package installs properly
* rpmlint produces 4 warnings, safe to ignore (spelling).
  2 packages and 0 specfiles checked; 0 errors, 0 warnings.
* final provides and requires are sane
* %check is present and all tests pass.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

I trust you can correct the BR before uploading and building in the CVS.

** APPROVED **

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.