[Bug 581280] Review Request: erlang-oauth - An Erlang OAuth implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581280

--- Comment #3 from Peter Lemenkov <lemenkov at gmail.com> 2010-05-12 10:54:15 EDT ---
(In reply to comment #2)

> * Why are you disabling debuginfo?

I switched it off just to be sure that no bogus empty *-debuginfo subpackage
will be produced. I just checked and it seems that I don't need to explicitly
disable it. 

> * With the erlang split, is BuildRequires: erlang really appropriate? What
> about Requires: erlang? If possible, this should be limited to the required
> erlang subpackages only.

Yes, definitely. I will try to build exact list of dependencies for this (and
other) package(s). However, automatic dependency generator for Erlang provides
too much data => I had to disable it in Fedora until we find more suitable
solution => it will costs me few hours to create list of dependencies.

> * The license is not BSD, it is MIT.

Ok, fixed.

> Also, the source code contains no license
> attribution, you should ask upstream to add it.

Ok, I will ask. Hope that this is not a blocker.

> * It is not necessary to set BuildRoot or delete it during %install anymore,
> see https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag (EPEL 4
> and 5 still require it, but if you're not planning on building for those
> targets, you can remove these lines)    

Yes - I plan to push it to EPEL as well, so I need to keep some obsoleted
packaging stuff.

I will provide updated package very soon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.