[Bug 566405] Review Request: nmbscan - A NMB/SMB network scanner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566405

Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |martin.gieseking at uos.de
               Flag|                            |fedora-review?

--- Comment #9 from Martin Gieseking <martin.gieseking at uos.de> 2010-05-12 15:56:57 EDT ---
Since nobody else seems to be interested in this package, I take the review. :)
Matthias already did a good job with his informal review, and there are just
two cosmetic things left I would address:

- Add a comment to the %build section telling that there's nothing to build.

- As suggested by the spell checker, capitalize "Ethernet" in the %description.
The other spelling errors can be ignored.


$ rpmlint /var/lib/mock/fedora-12-x86_64/result/*.rpm
nmbscan.noarch: W: spelling-error %description -l en_US hostname -> host name,
host-name, hostage
nmbscan.noarch: W: spelling-error %description -l en_US ethernet -> Ethernet,
ether net, ether-net
nmbscan.noarch: W: spelling-error %description -l en_US username -> user name,
user-name, whatshername
nmbscan.src: W: spelling-error %description -l en_US hostname -> host name,
host-name, hostage
nmbscan.src: W: spelling-error %description -l en_US ethernet -> Ethernet,
ether net, ether-net
nmbscan.src: W: spelling-error %description -l en_US username -> user name,
user-name, whatshername
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

---------------------------------
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    - GPLv2 according to text in shell script

[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum nmbscan-1.2.5.tar.gz*
    7cbfd9c7ea817e67525006e78fb5d32e  nmbscan-1.2.5.tar.gz
    7cbfd9c7ea817e67525006e78fb5d32e  nmbscan-1.2.5.tar.gz.1

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    - shell script doesn't need to be built
    - package builds in koji:
      http://koji.fedoraproject.org/koji/taskinfo?taskID=2183527

[.] MUST: If the package does not successfully compile ...
[+] MUST: All build dependencies must be listed in BuildRequires.
    - none required

[.] MUST: The spec file MUST handle locales properly.
    - no locales

[.] MUST: Packages storing shared library files must call ldconfig in %post and
%postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix ...
[.] MUST: devel packages must require the base package 
[+] MUST: Packages must NOT contain any .la libtool archives
[.] MUST: Packages containing GUI applications ...
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[+] SHOULD: The reviewer should test that the package builds in mock.
    - builds in mock

[.] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
    - noarch package

[+] SHOULD: The reviewer should test that the package functions as described.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) should be placed in a -devel pkg.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.