[Bug 591312] Review Request: maven-compiler-plugin - Maven Compiler Plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591312

Alexander Kurtakov <akurtako at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(akurtako at redhat.c |
                   |om)                         |

--- Comment #3 from Alexander Kurtakov <akurtako at redhat.com> 2010-05-12 16:28:24 EDT ---
(In reply to comment #2)
> According to the guidelines for maven spec files, jpackage-utils should be
> required.  In addition, the post and postun steps should require
> jpackage-utils.
> 
Fixed.

> Please fix or comment on the following rpmlint warnings/errors:
> 
> rpmlint on spec file:
> 
> maven-compiler-plugin.spec: W: invalid-url Source0:
> maven-compiler-plugin-2.0.2.tar.xz
> 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
There is no source released from upstream just svn tag.


> 
> rpmlint on binaries:
> 
> bash $ rpmlint maven-compiler-plugin-2.0.2-1.fc14.noarch.rpm 
> maven-compiler-plugin.noarch: E: no-changelogname-tag
I can not see this one.

> maven-compiler-plugin.noarch: W: unexpanded-macro Provides
> maven2-plugin-compiler = %{epoch}:2.0.2-1.fc14 %{epoch}
Fixed.

> maven-compiler-plugin.noarch: W: no-documentation
No documentation provided.
> maven-compiler-plugin.noarch: W: non-conffile-in-etc
> /etc/maven/fragments/maven-compiler-plugin
False positive.
> 1 packages and 0 specfiles checked; 1 errors, 3 warnings.
> 
> bash $ rpmlint maven-compiler-plugin-javadoc-2.0.2-1.fc14.noarch.rpm 
> maven-compiler-plugin-javadoc.noarch: E: no-changelogname-tag
I cannot see this.
> 1 packages and 0 specfiles checked; 1 errors, 0 warnings.    

New sources:
Spec URL: http://akurtakov.fedorapeople.org/maven-compiler-plugin.spec
SRPM URL:
http://akurtakov.fedorapeople.org/maven-compiler-plugin-2.0.2-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.