[Bug 591222] gtk3 - version 3 of GTK+

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591222

--- Comment #4 from Matthias Clasen <mclasen at redhat.com> 2010-05-14 20:38:40 EDT ---
(In reply to comment #3)
>
> 
> >  o I am bit surprised about various hacks, push at least some
> >    of the changes upstream?    
> 
> Indeed. Or is this not (easyly) possible?

Spell out what you consider 'hacks', maybe ? The multilib support crap is not
upstreamable, because multilib is a RHism that I don't want to spread upstream.

> 
> Some other comments:
> - rpmlint (just the relevant ones):
> gtk3.src: W: strange-permission update-gdk-pixbuf-loaders-3.0 0775L
> gtk3.src: W: strange-permission update-gtk-immodules-3.0 0775L
> 
> * Why not 755?

No specific reason. I can change it.

> 
> gtk3.src:125: W: mixed-use-of-spaces-and-tabs (spaces: line 125, tab: line 125)
> gtk3.src: W: invalid-url Source0:
> http://download.gnome.org/sources/gtk+/3.0/gtk+-2.90.0.tar.bz2 HTTP Error 404:

I'll fix that.

> - Could you please use INSTALL="install -p" to preserve timestamps?
>   (also when installing the examples)

I still have to find somebody how can show me an actual benefit of timestamp
pedantry. (Beyond making reviewers happy...)

> - It's a bit confusing to use $host and %{_host}, almost impossible to verify
> as a reviewer...
>   Could you explain them a bit?

It has plenty of comments in the spec:

# Deriving /etc/gtk-3.0/$host location
...
# Make sure that the host value that is passed to the compile
# is the same as the host that we're using in the spec file

So:
GTK+ is looking up files there at runtime. Some of the files are
arch-dependent, thus we must factor $host into the path. The rest of the
'hack' deals with the fact that rpm has its own idea of host triplet, and
we need to make sure that the host triplet that GTK+ uses at runtime (which is
the one coming from config.guess and compiled into the library) is the same
that we use to when putting the files in their place.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.