[Bug 592223] Review Request: buildnotify - Cruise Control build monitor for GNU/Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592223

--- Comment #4 from Balaji Damodaran <damodaran.balaji at gmail.com> 2010-05-15 07:05:49 EDT ---
(In reply to comment #3)
> just a quick note,
> 
> - changelog missing
> - Version should be 0.2.5
> - release version is 5 ? should it be 2 ?
> - http://bitbucket.org/Anay/buildnotify/get/buildnotify.tar.gz - NOT FOUND
> - Let rpm handle Requires,so need to specify them explicitly
> - %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
> %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
> distutils.sysconfig import get_python_lib; print(get_python_lib())")}
> %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
> distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
> %endif -- put this at the top of the SPEC file.    

incorporated the suggested changes. Please find the modified files in the
following location:

Spec URL:
http://github.com/openbala/buildnotify-rpm/blob/master/buildnotify.spec

SRPM URL:
http://github.com/openbala/buildnotify-rpm/blob/master/buildnotify-0.2.5-1.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.