[Bug 592670] Review Request: mongoose - An easy-to-use self-sufficient web server

bugzilla at redhat.com bugzilla at redhat.com
Tue May 18 08:35:31 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592670

--- Comment #4 from Chen Lei <supercyper1 at gmail.com> 2010-05-18 04:35:30 EDT ---

> do some tests. Please, let me know if you observation [1] is a real blocker to
> this package. 
> [6] As you may notice, there is no install section on Makefile delivered by
> upstream, so I have the real need of being using %{__install} macros. IMHO, it 
> would be preferable using this macros than the commands itself, wouldn' be?

1.New packagers should avoid of using unnecessarily macros, e.g. %{__rm}
%{__install} %{__ln_s} etc, those macros are useless for fedora.

2. You can include examples in %doc


See https://fedoraproject.org/wiki/Packaging_tricks

3. As Terje RÃ said, you should list man pages in this way:
%{_mandir}/man1/%{name}.1*, because fedora may switch manpages from gz to other
compression format in some time.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list