[Bug 578480] Review Request: spectrum - XMPP transport/gateway

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578480

--- Comment #6 from Matej Cepl <mcepl at redhat.com> 2010-05-19 03:30:09 EDT ---
We have progress, 0.2 with some patches now builds on EPEL-5
http://koji.fedoraproject.org/koji/taskinfo?taskID=2196133 (we need
ExcludeArch: ppc though)

Also upgraded to 0.2 and fixed some nits.

However, rpmlint is very unhappy about us (omitting some spelling nonsenses):

johanka:build$ rpmlint  -i RPMS/x86_64/spectrum-*
spectrum.x86_64: E: non-readable /etc/spectrum/spectrum.cfg 0640L
The file can't be read by everybody. If this is expected (for security
reasons), contact your rpmlint distributor to get it added to the list of
exceptions for your distro (or add it to your local configuration if you
installed rpmlint from the source tarball).

spectrum.x86_64: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/spectrum
The package contains an init script that does not contain one of the LSB init
script comment block convention keywords that are recommendable for all init
scripts.  If there is nothing to add to a keyword's value, include the keyword
in the script with an empty value.  Note that as of version 3.2, the LSB
specification does not mandate presence of any keywords.

spectrum.x86_64: E: subsys-not-used /etc/rc.d/init.d/spectrum
While your daemon is running, you have to put a lock file in
/var/lock/subsys/. To see an example, look at this directory on your machine
and examine the corresponding init scripts.

2 packages and 0 specfiles checked; 2 errors, 6 warnings.
johanka:build$ 

------------------------------------------

The first one is probably harmless, but I am not sure about the remaining ones.
I was looking at your init.d script and wasn't sure how is it supposed to work
.... should it be possible to run spectrum multiple times?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.