[Bug 593879] Review Request: libvpx - VP8 Video Codec SDK

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593879

Dennis Gilmore <dennis at ausil.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |dennis at ausil.us
               Flag|                            |fedora-review?

--- Comment #2 from Dennis Gilmore <dennis at ausil.us> 2010-05-19 19:00:32 EDT ---
rpmlint /var/lib/mock/fedora-13-x86_64/result
libvpx-utils.x86_64: W: no-documentation
libvpx-utils.x86_64: E: non-standard-executable-perm
/usr/bin/vp8_scalable_patterns 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm
/usr/bin/twopass_vp8_encoder 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/decode_to_md5
0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/vp8cx_set_ref
0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/force_keyframe
0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/example_xma 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/postproc 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/decode_with_drops
0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/error_resilient
0775L
libvpx-utils.x86_64: E: non-standard-executable-perm
/usr/bin/simple_vp8_encoder 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/ivfenc 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm
/usr/bin/simple_vp8_decoder 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/ivfdec 0775L
libvpx-utils.x86_64: E: non-standard-executable-perm /usr/bin/vp8_set_maps
0775L
libvpx.src: W: spelling-error %description -l en_US codec -> codex, code, codes
libvpx.src:51: W: rpm-buildroot-usage %build DIST_DIR=%{buildroot} ./configure
--target=generic-gnu --enable-pic --disable-optimizations --enable-debug
libvpx.src:51: W: configure-without-libdir-spec
libvpx.src: W: no-cleaning-of-buildroot %install
libvpx.src: W: no-buildroot-tag
libvpx.src: W: invalid-url Source0:
http://webm.googlecode.com/files/libvpx-0.9.0.tar.bz2 HTTP Error 404: Not Found
libvpx.x86_64: W: spelling-error %description -l en_US codec -> codex, code,
codes
5 packages and 0 specfiles checked; 14 errors, 8 warnings.


permissions we should fix

i think that rather than doing the rename of the utils to 
/usr/bin/simple_vp8_decoder
/usr/bin/simple_vp8_encoder
/usr/bin/twopass_vp8_encoder

we should name them 
/usr/bin/vp8_simple_decoder
/usr/bin/vp8_simple_encoder
/usr/bin/vp8_twopass_encoder

which is consistent with some of the other included utils namely 

/usr/bin/vp8_scalable_patterns
/usr/bin/vp8_set_maps

upstream source matches
sha256sum fedora/SOURCES/libvpx-0.9.0.tar.bz2 Download/libvpx-0.9.0.tar.bz2 
a0096ac6859cfb61cf06dd9bc0a79a3333a4ec389ba311911d84df8ff2a1b9dc 
fedora/SOURCES/libvpx-0.9.0.tar.bz2
a0096ac6859cfb61cf06dd9bc0a79a3333a4ec389ba311911d84df8ff2a1b9dc 
Download/libvpx-0.9.0.tar.bz2


builds fine in mock

SPEC is clear and legible

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.