[Bug 593841] Review Request: wicd - Wireless and wired network connection manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593841

--- Comment #9 from Christoph Wickert <cwickert at fedoraproject.org> 2010-05-21 20:00:33 EDT ---
You are not to disable NetworkManager or even to turn on wicd by default, see
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Why_don.27t_we....

You are already making 3 packages. Why not make a 4th one for the pm-utils
scripts so that all the other stuff can be noarch as it should?

How about naming the base package wicd-common instead of just wicd? The common
indicated that it's not the full wicd package but just shared files between
other packages.

You should pass more options to configure, at least --distro=redhat. I think
other options like --share or --lib should be passed as well, then somebody can
build the package with rpmbuild --rebuild --define=_datadir /foo/shared.

Please don't specify the extension of manpages. Imagine we switch from gz to
bz2.

The files in %{_datadir}/man/nl must be tagged with %lang(nl)

The package must not own %{_datadir}/icons/hicolor and folders below. It only
should own the icons. For directory ownership you can require
hicolor-icon-theme, but this is not needed as it is already required by gtk2
(through pygtk2)

%dir %{_datadir}/wicd/curses
%{_datadir}/wicd/curses/*
is the same as
%{_datadir}/wicd/
Using %dir here only makes sense if you want to exclude certain files (because
they should go into another package).

%{_sysconfdir}/xdg/autostart/wicd-tray.desktop is not a config file. Changes
are made in the private ~/.config/autostart namespace.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.