[Bug 593839] Review Request: python-urwid - Console user interface library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593839

--- Comment #18 from Peter Lemenkov <lemenkov at gmail.com> 2010-05-22 00:40:09 EDT ---
(In reply to comment #16)

> One concern raised is whether or not python-urwid should require
> python-twisted-core or pygobject2.  I cannot tell what the conclusion on that
> was, so I did not add either.  My personal take on it that since the module
> wraps the import statements in try/except blocks, python-urwid should be fine. 
> If users want the twisted functionality, they can install the
> python-twisted-core package.  If anything dependent on python-urwid requires
> the twisted usage inside python-urwid, then that package can Require both
> python-urwid and python-twisted-core.

Then you *must* edit ./test_urwid.py and exclude checks dependent on twisted.
You can also add twisted as buildrequires and not as requires (just for faking
test results), but I don't think it's a good idea.

Otherwise package looks good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.