[Bug 592770] Review Request: texmakerx - LaTex Editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592770

--- Comment #8 from Rafael Aquini <aquini at linux.com> 2010-05-22 14:52:17 EDT ---
Johannes,

(In reply to comment #7)
> It takes really long to compile this package despite my pc is recent. So I
> don't want to compile it the whole day, sorry.
Well, if the question was just a matter of rebuilding and shipping a new SRPM
without having to go through your long build process, I think a simple
'rpmbuild -bs texmakerx.spec' would be sufficient to you.

> I didn't know that you have to change the release number everytime you change
> the spec. I'll do in the future...
Yes, whenever a minor change (spec file changed, patch added/removed) occurs,
or a package is rebuilt to use newer headers or libraries, the release number
should be incremented. You can find further information on this subject at:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Release

Here has a good reference, also:
http://fedoraproject.org/wiki/Packaging/FrequentlyMadeMistakes



Well, it seems to me that your package is OK.

1) rpmlint does not have any complaint at all:
$ rpmlint -i SPECS/texmakerx.spec SRPMS/texmakerx-1.9.9-2.fc12.src.rpm
RPMS/x86_64/texmakerx-1.9.9-2.fc12.x86_64.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

2) mock build is OK, too
$ mock -r fedora-12-x86_64 --rebuild SRPMS/texmakerx-1.9.9-2.fc12.src.rpm
INFO: mock.py version 1.0.7 starting...
State Changed: init plugins
State Changed: start
INFO: Start(SRPMS/texmakerx-1.9.9-2.fc12.src.rpm)  Config(fedora-12-x86_64)
.
.
INFO: Done(SRPMS/texmakerx-1.9.9-2.fc12.src.rpm) Config(fedora-12-x86_64) 8
minutes 38 seconds
INFO: Results and/or logs in: /var/lib/mock/fedora-12-x86_64/result


I hope you get your work formally reviewed by a sponsor, very soon!


Regards

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.