[Bug 592733] Review Request: turpial - Is cool twitter client with many features and very light

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592733

--- Comment #6 from Chen Lei <supercyper1 at gmail.com> 2010-05-22 21:44:27 EDT ---
1.The biggest problem for this package is the location for locale. The right
place for them should be /usr/share/locale/, the upstream must fix them. I
suggest you send a patch to upstream,
/usr/lib/python2.6/site-packages/turpial/i18n is not the appropriate place for
them.

2. the release number is wrong, it should be 0.1.a1

See fedora naming guideline


3.
/usr/share/doc/turpial -> /usr/share/doc/turpial-%{version}


4.
/usr/share/applications/turpial.desktop should some further modification.


e.g.

icon-> /usr/share/pixmaps/turpial.png

See 
http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
http://fedoraproject.org/wiki/Packaging_tricks#.desktop_files

5.

Please add a blank line between the changelog entries

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.